Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] func testing for data source management listing #325

Merged
merged 9 commits into from
Oct 18, 2022
Merged

[MD] func testing for data source management listing #325

merged 9 commits into from
Oct 18, 2022

Conversation

mpabba3003
Copy link
Contributor

@mpabba3003 mpabba3003 commented Oct 14, 2022 •
edited
Loading

Description

[MD] func testing for data source management listing

Issues Resolved

opensearch-project/OpenSearch-Dashboards#2576

Screenshots

2_datasource_table.spec.js.mp4

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mpabba3003 mpabba3003 requested a review from a team as a code owner October 14, 2022 17:30
@mpabba3003 mpabba3003 self-assigned this Oct 14, 2022
@mpabba3003 mpabba3003 added backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 14, 2022
@mpabba3003 mpabba3003 requested a review from noCharger October 14, 2022 18:32
@mpabba3003 mpabba3003 mentioned this pull request Oct 14, 2022
Closed
1 task
@mpabba3003
lint
2fa77aa 
Signed-off-by: mpabba3003 <[email protected]>
@mpabba3003
updating timeout to 1800
c091b88 
Signed-off-by: mpabba3003 <[email protected]>
@tianleh
Copy link
Member

tianleh commented Oct 15, 2022

related to opensearch-project/opensearch-build#2743

noCharger
noCharger reviewed Oct 15, 2022
View reviewed changes
cypress.json Show resolved Hide resolved
.github/workflows/release-e2e-workflow-template.yml Outdated Show resolved Hide resolved
@tianleh
Copy link
Member

tianleh commented Oct 17, 2022

The bundle test workflow will fail due to this opensearch-project/opensearch-build#2743

@tianleh
Copy link
Member

tianleh commented Oct 18, 2022 •
edited
Loading

Since 3.0.0 latest is not stable and your PR changed the bundle workflow, one workaround is to send a PR against 2.x branch so that it can trigger a workflow against 2.4.0 (Similar to https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3253106118/jobs/5340048924#logs)

We can check if the "Bundle Snapshot based E2E Cypress tests workflow for core Dashboards" is successful against 2.4.0. (The dummy PR to 2.x branch could be discarded after the validation.)

@mpabba3003 @yibow98

@tianleh tianleh mentioned this pull request Oct 18, 2022
Merged
2 tasks
@yibow98 yibow98 mentioned this pull request Oct 18, 2022
Closed
1 task
@yibow98
Copy link
Contributor

yibow98 commented Oct 18, 2022

Since 3.0.0 latest is not stable and your PR changed the bundle workflow, one workaround is to send a PR against 2.x branch so that it can trigger a workflow against 2.4.0 (Similar to https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3253106118/jobs/5340048924#logs)

We can check if the "Bundle Snapshot based E2E Cypress tests workflow for core Dashboards" is successful against 2.4.0. (The dummy PR to 2.x branch could be discarded after the validation.)

@mpabba3003 @yibow98

I raised a PR against 2.x branch and the Bundle Snapshot based E2E Cypress tests workflow for core Dashboards" is successful against 2.4.0. Reference: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3275360924/jobs/5390106545. Please ignore the one of cypress test case failed, I will fix it in my code. All other check pass.

@mpabba3003
Copy link
Contributor Author

Since 3.0.0 latest is not stable and your PR changed the bundle workflow, one workaround is to send a PR against 2.x branch so that it can trigger a workflow against 2.4.0 (Similar to https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3253106118/jobs/5340048924#logs)

We can check if the "Bundle Snapshot based E2E Cypress tests workflow for core Dashboards" is successful against 2.4.0. (The dummy PR to 2.x branch could be discarded after the validation.)

@mpabba3003 @yibow98

Please take a look at #336 to check if all tests are passing or not

@tianleh
Copy link
Member

tianleh commented Oct 18, 2022

See that the tests are passing for 2.4 https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3275760558/jobs/5391007264 Great work!

@tianleh tianleh mentioned this pull request Oct 18, 2022
Closed
1 task
@tianleh
Copy link
Member

tianleh commented Oct 18, 2022

Rerun https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3275934146/jobs/5392212603 is now successful on this PR

@tianleh tianleh merged commit 25bd809 into opensearch-project:main Oct 18, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2022
@mpabba3003 @github-actions
[MD] func testing for data source management listing (#325)
d2502a7 
* [MD][PoC] Multiple data source create credential use case

* func testing for data source management listing & es lint on few existing files

* updating the datasource listing tests with new features

Signed-off-by: mpabba3003 <[email protected]>

* refactoring create button test

Signed-off-by: mpabba3003 <[email protected]>

* adding feature flag and Re-org folder structure

Signed-off-by: mpabba3003 <[email protected]>

* lint

Signed-off-by: mpabba3003 <[email protected]>

* updating timeout to 1800

Signed-off-by: mpabba3003 <[email protected]>

* optimizing test cases run time & re-org utils/plugin/datasource -> utils/dashboards/datasource

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
Co-authored-by: Louis Chu <[email protected]>
(cherry picked from commit 25bd809)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 18, 2022
Merged
tianleh pushed a commit that referenced this pull request Oct 19, 2022
@opensearch-trigger-bot
[MD] func testing for data source management listing (#325) (#338)
ec235ed
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
@mpabba3003 @noCharger @jakubp-eliatra
[MD] func testing for data source management listing (opensearch-proj…
fcb42f9 
…ect#325)

* [MD][PoC] Multiple data source create credential use case

* func testing for data source management listing & es lint on few existing files

* updating the datasource listing tests with new features

Signed-off-by: mpabba3003 <[email protected]>

* refactoring create button test

Signed-off-by: mpabba3003 <[email protected]>

* adding feature flag and Re-org folder structure

Signed-off-by: mpabba3003 <[email protected]>

* lint

Signed-off-by: mpabba3003 <[email protected]>

* updating timeout to 1800

Signed-off-by: mpabba3003 <[email protected]>

* optimizing test cases run time & re-org utils/plugin/datasource -> utils/dashboards/datasource

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
Co-authored-by: Louis Chu <[email protected]>
Signed-off-by: Jakub Przybylski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenTian kristenTian kristenTian approved these changes

@tianleh tianleh tianleh approved these changes

@yibow98 yibow98 Awaiting requested review from yibow98

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@noCharger noCharger Awaiting requested review from noCharger

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

Assignees

@mpabba3003 mpabba3003

Labels
backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mpabba3003 @tianleh @yibow98 @noCharger @CCongWang @kristenTian